(dev/mail/5) "New Mailing" - Previews should not schedule real blasts #11904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `CRM_Mailing_BAO_Mailing::create` and `Mailing.create` API, there is a (*ahem*) special behavior where setting the `scheduled_date` will immediately trigger scheduling. One shouldn't submit `scheduled_date` for a preview. This was not symptomatic before civicrm#11142/v4.7.31 because all preview operations were wrapped in a transaction and rolled back. But now previews are allowed to have side-effects, so we need some other means to prevent. This copies the workaround from `crmMailingMgr.save()` and applies it to `crmMailingMgr.preview()` (etal).
seamuslee001
approved these changes
Mar 30, 2018
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In
CRM_Mailing_BAO_Mailing::createandMailing.createAPI, there is a(ahem) special behavior where setting the
scheduled_datewillimmediately trigger scheduling. One shouldn't submit
scheduled_datefor apreview.
See: https://lab.civicrm.org/dev/mail/issues/5
Before
If one tentatively sets a delivery time and previews, then it prematurely schedules a MailingJob.
After
If one tentatively sets a delivery time and previews, then it does not prematurely schedule a MailingJob.
Technical Details
This was not symptomatic before #11142/v4.7.31 because all preview
operations were wrapped in a transaction and rolled back. But now previews
are allowed to have side-effects, so we need some other means to prevent.
This copies the workaround from
crmMailingMgr.save()and appliesit to
crmMailingMgr.preview()(etal).